This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: download recursive#1838
Merged
Merged
Conversation
namchuai
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Changes made
This pull request includes several changes to improve error handling, simplify code, and enhance compatibility across different operating systems. The most important changes include adding error handling for model loading, modifying permission settings for Python virtual environments, and improving URL handling.
Error handling improvements:
engine/extensions/python-engine/python_engine.cc: Added error handling to check if the model is loaded in theHandleInferenceandHandleRouteRequestmethods. If the model is not loaded, an error response is generated and returned. [1] [2]Code simplification:
engine/services/model_service.cc: Simplified the code by removing conditional compilation directives for setting executable permissions on different operating systems and applying the permissions uniformly.Enhanced URL handling:
engine/utils/curl_utils.cc: Improved theSimpleGetJsonRecursivefunction by usingstd::filesystem::pathto handle URL paths more robustly.